1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/js_bbs.cpp

    From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Sat Nov 9 20:30:54 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/c9ec49e0f40b8af1e975bf09
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    Fix logic in bbs.xfer_prot_menu()

    This was just a typo which didn't allow the single-file upload xfer prot menu to be shown.

    Actual fix for CID 11447 (previous attempt, commit f50c866fd was
    insufficient). Thank you Coverity!

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sat Nov 30 01:45:10 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/52460c3abc163308c7be1c62
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    Range check argc before deref of argv[1]

    Apparently JSVAL_IS_STRING() can return true even when argv[1] is out of range (I guess I assumed it'd alwasy be NULL or VOID/undefined) and this can lead to crash when calling JS_ValueToString() on it.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Mon Dec 9 19:15:31 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/6dbd2fec644cd1f153137bc2
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    Support text.dat string IDs (string) args for replace/revert_text() funcs

    For alignment with the text() method and for instances where a script author doesn't want to load('text.js') or use [bbs|system].text.ID to get a text.dat string index from an ID.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Tue Dec 10 16:28:49 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/9f3d653e0cf46d0eacb2e0b2
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    Add missing space to JSDOC HTML output
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Mon Jan 20 13:08:30 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/b0a3cfe5e2fbaa7063ad6ec6
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    Fix bbs.compare_ars() called with no params

    Throws an exception now instead of using uninitialized args:

    ;eval
    Parameter(s): bbs.compare_ars()
    InternalError: allocation size overflow

    Updated JSDOCS for methods (mostly just adding punctuation). Fixed a typo
    or two.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Debian Linux)@VERT to Git commit to main/sbbs/master on Mon Jan 20 13:08:30 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/b9bbf9b671f84005d838bfc9
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    Better parameter validation in bbs methods

    More method will now throw exception if called without args: bbs.check_filename(), bbs.logkey(), bbs.export_filelist()

    bbs.check_syspass() will prompt for system password if passed null or undefined value.

    Fix (and document) the optional channel argument to bbs.multinode_chat()
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Thu Jan 23 17:10:49 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/2f959775a435a537449edee8
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    Pretty sure this period is supposed to be inside the quotes...
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on ChromeOS)@VERT to Git commit to main/sbbs/master on Thu Jan 23 23:05:20 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/c2e49c12d281d7df7f7a6dd6
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    This period was supposed to be there at all
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on ChromeOS)@VERT to Git commit to main/sbbs/master on Sat Jan 25 21:51:00 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/aa258686f3d08ce6bdca8f65
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    bbs.revert_text() (called with no args) is supposed to revert all text strings

    and not throw and exception. :-(

    This was broken in commit 6dbd2fec644cd1f153137bc27432cf3e127ca81a

    Caught by code review.
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Mon Feb 3 18:56:14 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/b5b06c7c79901ba8f1a17296
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    bbs.load_text() can now be used to load text*.ini file

    For sysops that don't want to use the user's chosen language to auto-load alternate text strings, they can specify some other filename from the ctrl directory (so long as it ends in .ini). I wouldn't use text.*.ini however, since those filenames are assumed to be language translations and will automatically appear in user_settings.js as a user-selectable language. text-*.ini would be fine though as an alternate text.ini filename:
    not colliding with text.ini or text.*.ini
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Deuc¿@VERT to Git commit to main/sbbs/master on Sun Mar 30 11:56:12 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/667c51a7cc5380aaa1b2ab87
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    Fix Win32 build?
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Mon Mar 31 15:28:25 2025
    https://gitlab.synchro.net/main/sbbs/-/commit/0d74bbba40c820c00d8146b6
    Modified Files:
    src/sbbs3/js_bbs.cpp
    Log Message:
    Fix GCC warning: `js_bbs_class' initialized and declared `extern'
    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net